Skip to content

gh-121376: Switch from stat.st_mtime to stat.mtime_ns to achieve more accuracy #121502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

gh-121376: Switch from stat.st_mtime to stat.mtime_ns to achieve more accuracy #121502

wants to merge 1 commit into from

Conversation

@Eclips4
Copy link
Member

@Eclips4 Eclips4 commented Jul 8, 2024 •
edited by bedevere-app bot
Loading

@Eclips4 Eclips4 marked this pull request as draft July 8, 2024 18:16
@bedevere-app bedevere-app bot mentioned this pull request Jul 8, 2024
Open
@Eclips4
Copy link
Member Author

Eclips4 commented Jul 8, 2024 •
edited
Loading

This is a PoC.
If this is a right solution, the same change should be applied to compileall/py_compile (but it would be more difficult), so failures in py_compile and compileall(and couple of other tests..)are expected.

@Zheaoli @nekopsykose can you confirm this is resolves problem on your systems?
(Note: this PR only modifies Python code, but some parts of the importlib module are frozen during the compilation process of the interpreter, so you will need to rebuild the interpreter in order to apply these changes.)

@nekopsykose
Copy link

it fixes it, yeah

@Eclips4
Copy link
Member Author

Eclips4 commented Jul 10, 2024

Closing per #121376 (comment)

@Eclips4 Eclips4 closed this Jul 10, 2024
@Eclips4 Eclips4 deleted the issue-121376 branch July 10, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Eclips4 @nekopsykose